pageserver: simplify block_deletions
handling
#10261
Draft
+1,036
−245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Upload queue reordering from #10218 may allow us to simplify the handling of
block_deletions
(such as #9844). Quote from internal Slack thread:Summary of changes
Block deletions in old generations in
UploadQueue::is_ready()
, and rely onUploadOp::can_bypass()
to allow writes in the current generation to bypass the queue.