-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spectator): Support input signals #638
Conversation
Run & review this pull request in StackBlitz Codeflow. |
This is not ready to merge, see #637 |
BREAKING CHANGE: remove 'props' and 'setProps' from host/directive factories
LGTM, let's finish it |
Fixed type names of InferSignalInputs and InputSignalInput (which was a typo) to be aligned with Angular's InputSignal type, rather than SignalInput
@NetanelBasal I added some cleanup commits, are there any specific changes to docs or other changes you'd like me to make do to ensure this is in a good state to merge? I'd be glad to take them up 😄 |
We need to update the README to reflect this change:
|
Added disclaimers for createHostFactory, createDirectiveFactory, and createPipeFactory as they don't support props/setProps anymore.
Great suggestion, thanks! I added some changes to the README but if you want to make any further changes, go ahead 😄 you're much more familiar with the writing style of docs in this repo, so please make any changes you want. (edit: I added you as collaborator to the fork so you can add any commits you want) |
PR Checklist
Please check if your PR fulfills the following requirements:
SpectatorDirectiveFactory
,SpectatorHostFactory
and their related types need some cleanup as the component's generic param is not used everywherePR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #637
What is the new behavior?
Does this PR introduce a breaking change?
setProps
andprops
were removed fromcreateHostFactory
andcreateDirectiveFactory
. Props should be set throughsetHostProps
andhostProps
instead.Other information