Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language support for Modelica #1262

Merged
merged 11 commits into from
Dec 29, 2024
Merged

Language support for Modelica #1262

merged 11 commits into from
Dec 29, 2024

Conversation

dietmarw
Copy link
Contributor

Purpose

Adding language support and icon art for Modelica.

Logo Reference

m_ball

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this won't be possible right now because our current tool for language detection doesn't support Modelica. We'd need tokei to support Modelica, and also have a new release featuring that support.

That's the most significant blocking issue currently, though we may eventually switch tools for language detection.

languages.yaml Outdated Show resolved Hide resolved
@dietmarw
Copy link
Contributor Author

I noticed the missing tokei support too and have now submitted a PR for that: XAMPPRocky/tokei#1061

@dietmarw
Copy link
Contributor Author

@spenserblack Regarding #1152 , is there anything I could already do wrt adding Modelica in case that is resolved before
XAMPPRocky/tokei#1061 ?

@spenserblack
Copy link
Collaborator

Yeah you can make an issue or PR into https://github.com/spenserblack/gengo if you want. What's most important is knowledge, not code, so an issue is sufficient, but PRs are very welcome!
I can't say when we'll switch over from tokei to gengo, but I'm pretty confident that we can at least deploy new languages more rapidly (and also resolve language ambiguity) when we do.

languages.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, contribution LGTM. The only thing that's left is us resolving upstream issues, so I'm approving this.

@dietmarw
Copy link
Contributor Author

Upstream has just merged the addition: XAMPPRocky/tokei#1061

@spenserblack
Copy link
Collaborator

We'll need to wait for the next release.

Copy link
Owner

@o2sh o2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @dietmarw 🎉

I took the liberty to clean the ASCII logo slightly https://vercel-gjf16v1xk-o2shs-projects.vercel.app/#Modelica

The PR should be ready to be merged

@o2sh o2sh merged commit 4cf8f8d into o2sh:main Dec 29, 2024
4 checks passed
@o2sh o2sh added feat and removed upstream labels Jan 1, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Jan 3, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [o2sh/onefetch](https://github.com/o2sh/onefetch) | minor | `2.22.0` -> `2.23.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>o2sh/onefetch (o2sh/onefetch)</summary>

### [`v2.23.1`](https://github.com/o2sh/onefetch/releases/tag/2.23.1)

[Compare Source](o2sh/onefetch@2.23.0...2.23.1)

<!-- Release notes generated using configuration in .github/release.yml at main -->

##### Bug Fixes 🐛

-   Fix version in man page

**Full Changelog**: o2sh/onefetch@2.23.0...2.23.1

### [`v2.23.0`](https://github.com/o2sh/onefetch/releases/tag/2.23.0)

[Compare Source](o2sh/onefetch@2.22.0...2.23.0)

<!-- Release notes generated using configuration in .github/release.yml at main -->

#### What's Changed

##### New Features 🎉

-   add language support for OpenSCAD by [@&#8203;kenchou](https://github.com/kenchou) in o2sh/onefetch#1502
-   add language support for Modelica by [@&#8203;dietmarw](https://github.com/dietmarw) in o2sh/onefetch#1262
-   add language support for ATS by [@&#8203;pykenny](https://github.com/pykenny) in o2sh/onefetch#523
-   add language support for CUDA by [@&#8203;jtmr05](https://github.com/jtmr05) in o2sh/onefetch#940
-   add missing nerd fonts icons for some languages by [@&#8203;ankddev](https://github.com/ankddev) in o2sh/onefetch#1491

##### Chores 🧹

-   add Italian translation of README by [@&#8203;tlazzarin](https://github.com/tlazzarin) in o2sh/onefetch#1435
-   add Polish translation of README by [@&#8203;adamperkowski](https://github.com/adamperkowski) in o2sh/onefetch#1444
-   add Czech translation of READEME by [@&#8203;Amereyeu](https://github.com/Amereyeu) in o2sh/onefetch#1439
-   update russian README by [@&#8203;ankddev](https://github.com/ankddev) in o2sh/onefetch#1478
-   \[onefetch.dev] migrate to Svelte v5 by [@&#8203;o2sh](https://github.com/o2sh) in o2sh/onefetch#1455
-   add script to preview/validate Nerd Fonts by [@&#8203;spenserblack](https://github.com/spenserblack) in o2sh/onefetch#1492
-   add Powershell snippet to run onefetch automatically by [@&#8203;kiapanahi](https://github.com/kiapanahi) in o2sh/onefetch#1453

#### New Contributors

-   [@&#8203;tlazzarin](https://github.com/tlazzarin) made their first contribution in o2sh/onefetch#1435
-   [@&#8203;kiapanahi](https://github.com/kiapanahi) made their first contribution in o2sh/onefetch#1453
-   [@&#8203;adamperkowski](https://github.com/adamperkowski) made their first contribution in o2sh/onefetch#1444
-   [@&#8203;Amereyeu](https://github.com/Amereyeu) made their first contribution in o2sh/onefetch#1439
-   [@&#8203;ankddev](https://github.com/ankddev) made their first contribution in o2sh/onefetch#1478
-   [@&#8203;kenchou](https://github.com/kenchou) made their first contribution in o2sh/onefetch#1502
-   [@&#8203;dietmarw](https://github.com/dietmarw) made their first contribution in o2sh/onefetch#1262
-   [@&#8203;pykenny](https://github.com/pykenny) made their first contribution in o2sh/onefetch#523
-   [@&#8203;jtmr05](https://github.com/jtmr05) made their first contribution in o2sh/onefetch#940

**Full Changelog**: o2sh/onefetch@2.22.0...2.23.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44Ni40IiwidXBkYXRlZEluVmVyIjoiMzkuODYuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
@dietmarw
Copy link
Contributor Author

dietmarw commented Jan 5, 2025

Thanks a lot for your contribution @dietmarw 🎉

I took the liberty to clean the ASCII logo slightly https://vercel-gjf16v1xk-o2shs-projects.vercel.app/#Modelica

The PR should be ready to be merged

Thanks @o2sh :-)

@dietmarw dietmarw deleted the newlanguage-modelica branch January 5, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants