update officers page and add committee heads #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cg505
requested review from
pxhanus,
BernardZhao,
Diplosaurus,
fydai and
ja5087
|
This is how it looks: |
|
There's a typo in the date for ethanhs- should be /19 for the year right? |
BernardZhao
approved these changes
Dec 12, 2019
Ha. I'll never reveal my time traveling secrets! |
emmatyping
approved these changes
Dec 12, 2019
ja5087
approved these changes
Dec 12, 2019
cg505
force-pushed
the
officers-update
branch
from
cac8671 to
cc6d18e
Compare
|
@64bitpandas good catch, fixed |
pxhanus
approved these changes
Dec 13, 2019
kpengboy
approved these changes
Dec 13, 2019
| @@ -80,6 +80,26 @@ <h4> | |||
| the OCF lab and other services. They are elected by the Board of | |||
| Directors at the end of each semester. | |||
| </p> | |||
| {% if current_term.heads|length > 0 %} | |||
There was a problem hiding this comment.
Is it possible to just say {% if current_term.heads %}?
There was a problem hiding this comment.
Not totally sure, but this is following the pattern of lines 36 and 65. I'll try to test it.
| @@ -24,12 +25,17 @@ def Term( | |||
| sms: List[Any], | |||
| dgms: Optional[List[Any]] = None, | |||
| dsms: Optional[List[Any]] = None, | |||
| heads: Optional[List[Tuple[str, List[Any]]]] = None, | |||
There was a problem hiding this comment.
Ideally we'd make the Anys more specific. Perhaps this can wait until we can use Python 3.7 data classes.
There was a problem hiding this comment.
This will get refactored anyways, assuming someone works on ocf/etc#3
fydai
approved these changes
Dec 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the officers page to include recent elections. It also adds committee heads to the officers page. I didn't add committee heads to the "previous officers" section, because I wasn't sure how to do it (and we don't have any official historical committee heads). We should think about if we want to do this and if so how.
Ideally this can be merged when the new terms take effect on December 21.