Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347141: Several javac tests compile with an unnecessary -Xlint:-path flag #22958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Jan 7, 2025

Please review this patch which removes unnecessary -Xlint:-path flags from a few javac regression tests.

These tests invoke the compiler with the -Xlint:all,-path flag, but the path option is unrelated to, and not needed for, the test.

The tests all succeed just fine without it, i.e., with -Xlint:all instead.

The suppression of the path lint category appears to be leftover cruft from long ago (at least, according to this discussion).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347141: Several javac tests compile with an unnecessary -Xlint:-path flag (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22958/head:pull/22958
$ git checkout pull/22958

Update a local copy of the PR:
$ git checkout pull/22958
$ git pull https://git.openjdk.org/jdk.git pull/22958/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22958

View PR using the GUI difftool:
$ git pr show -t 22958

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22958.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 7, 2025

@archiecobbs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347141: Several javac tests compile with an unnecessary -Xlint:-path flag

Reviewed-by: vromero, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
  • 49ee4df: 8166983: Remove old/legacy unused tzdata files
  • 3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
  • 55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
  • ae3fc46: 8345580: Remove const from Node::_idx which is modified
  • 4d18e5a: 8346872: tools/jpackage/windows/WinLongPathTest.java fails
  • 92ad8a1: 8346052: JFR: Incorrect average value in 'jfr view'
  • 672c413: 8345337: JFR: jfr view should display all direct subfields for an event type
  • afe5434: 8347163: Javadoc error in ConstantPoolBuilder after JDK-8342468
  • f696d9c: 8346239: Improve memory efficiency of JimageDiffGenerator
  • ... and 9 more: https://git.openjdk.org/jdk/compare/e413fc643c4a58e3c46d81025c3ac9fbf89db4b9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2025
@openjdk
Copy link

openjdk bot commented Jan 7, 2025

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jan 7, 2025

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2025
@archiecobbs
Copy link
Contributor Author

Thanks for the review!

Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; thanks.

@archiecobbs
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants