SDN-5579: virt, feat gates: the UDN CRD depends on the NetSeg feat gate #29407
Conversation
|
/cc @JoelSpeed |
|
/test e2e-aws-ovn-virt-techpreview |
As seen in [0], and [1] the UserDefinedNetwork CRD is only installed if the `NetworkSegmentation` feature gate is installed. [0] - https://github.com/openshift/cluster-network-operator/blob/9d96bcc4fc4653970e135a87ce380b0fb57f0587/bindata/network/ovn-kubernetes/common/001-crd.yaml#L3154 [1] - https://github.com/openshift/cluster-network-operator/blob/9d96bcc4fc4653970e135a87ce380b0fb57f0587/pkg/network/render.go#L655 Signed-off-by: Miguel Duarte Barroso <[email protected]>
maiqueb
force-pushed
the
persistent-ips-set-network-seg-feat-gate-on-udn-crd-tests
branch
from
c20156d to
e57743c
Compare
|
/lgtm |
|
/approve |
maiqueb
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@maiqueb: This pull request references SDN-5579 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JoelSpeed, knobunc, maiqueb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Did these run on any of the pre-submit jobs? I don’t see any techpreview in there. You should trigger them to make sure these tests pass. |
|
@stbenjam They already run in periodic tests, see https://sippy.dptools.openshift.org/sippy-ng/tests/4.19/details?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22contains%22%2C%22value%22%3A%22%5BOCPFeatureGate%3APersistentIPsForVirtualization%5D%22%7D%5D%7D where you can see them all already. This is just changing the name to include an additional feature gate, it shouldn't affect the actual tests themselves other than skipping them when the new gate is not enabled |
|
@maiqueb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
As seen in [0], and [1] the UserDefinedNetwork CRD is only installed if the
NetworkSegmentationfeature gate is installed - hence, we need to mark the UDN based tests with theNetworkSegmentationfeature gate.[0] - https://github.com/openshift/cluster-network-operator/blob/9d96bcc4fc4653970e135a87ce380b0fb57f0587/bindata/network/ovn-kubernetes/common/001-crd.yaml#L3154
[1] - https://github.com/openshift/cluster-network-operator/blob/9d96bcc4fc4653970e135a87ce380b0fb57f0587/pkg/network/render.go#L655