-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recovery: "mdb -k" should be at least basically functional #182
base: master
Are you sure you want to change the base?
Conversation
bb04861
to
2acc47a
Compare
This looks great! Given the presence of the shared objects, it feels like the p tools + gcore are also reasonable to add? A crude list:
These add up to less than 1MiB, and it feels like it would give us some pretty rich tooling. If |
We're still at 110MiB (was 107MiB before this PR) with those additional tools. |
With these changes,
|
Does adding nvmeadm (libnvme) or maybe diskinfo instead add much more on? I know from yesterday's debugging call we did not have a good way to list the disks on the stuck system. Edit: |
I've added both --rw-r--r-- 1 andy staff 113157199 Jan 8 17:04 /home/andy/installinator/zfs.img
+-rw-r--r-- 1 andy staff 116934599 Jan 8 16:58 /home/andy/installinator/zfs.img which at just under 4MiB, seems very reasonable for the additional tooling we get in case of problems - just under 30s extra transfer time via IPCC. |
This costs us around 3MiB so seems well worth it.