Allow building without usb/debug probes #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Humility was originally designed to be used with a variety of debug probes. It's since grown the ability to take dumps over the network. There are situations/environments where it's useful to run in network only mode. Allow building without debug probes with `cargo build --no-default-features`. To make this work with cargo features, the probes are pulled into a separate crate and the humility binary is moved to `humilty-bin`
mkeeter
reviewed
Jan 7, 2025
| @@ -10,3 +10,9 @@ clap.workspace = true | |||
| humility.workspace = true | |||
| humility-net-core.workspace = true | |||
| humility-cli.workspace = true | |||
|
|
|||
| humility-probes-core = {workspace = true, optional = true } | |||
There was a problem hiding this comment.
Nit:
Suggested change
| humility-probes-core = {workspace = true, optional = true } | |
| humility-probes-core = { workspace = true, optional = true } |
mkeeter
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Humility was originally designed to be used with a variety of debug probes. It's since grown the ability to take dumps over the network. There are situations/environments where it's useful to run in network only mode. Allow building without debug probes with
cargo build --no-default-features.To make this work with cargo features, the probes are pulled into a separate crate and the humility binary is moved to
humilty-bin