Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix :huawei touch not working #101

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

fix :huawei touch not working #101

wants to merge 11 commits into from

Conversation

tiodot
Copy link

@tiodot tiodot commented Mar 4, 2024

Touching to go next/prev page not working in the Huawei landtop, add an addEventListener of 'touchene'

Copy link

vercel bot commented Mar 4, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @pacexy on Vercel.

@pacexy first needs to authorize it.

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flow-reader ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2024 4:11am

const books = await db?.books.toArray()
const book = books?.find((b) => b.name === filename)

return (
book ??
fetch(url)
fetch(proxyGithubUrl(url))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, download book from Github will occur CORS error.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to move this to a new PR, but idk if we actually need this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I delete these code.

Copy link
Owner

@pacexy pacexy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to merge this PR. Could you explain with comments why addEventListener is needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants