-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix :huawei touch not working #101
base: main
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @pacexy on Vercel. @pacexy first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
apps/reader/src/file.ts
Outdated
const books = await db?.books.toArray() | ||
const book = books?.find((b) => b.name === filename) | ||
|
||
return ( | ||
book ?? | ||
fetch(url) | ||
fetch(proxyGithubUrl(url)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, download book from Github will occur CORS error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to move this to a new PR, but idk if we actually need this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I delete these code.
This reverts commit 9bbe1bc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to merge this PR. Could you explain with comments why addEventListener is needed?
Touching to go next/prev page not working in the Huawei landtop, add an addEventListener of 'touchene'