This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
using SOCIAL_APP_URL to provide a proper callback url #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran in to the problem of the callback URLs having localhost:5000 (
request.url_root[:-1]
) in them. Without having to use Flask's SERVER_NAME option, I decided to using the SOCIAL_APP_URL variable that was added to the app.config by default and not seemingly used anywhere else. I like the idea of using SOCIAL_APP_URL over SERVER_NAME since only the callbacks need full urls.I changed the behavior such that SOCIAL_APP_URL defaults to None. Thus, if not SOCIA_APP_URL is given, then request.url_root[:-1] is used for generating the callback urls.