Use curl to fetch k6 binary with CURLOPT_FOLLOWLOCATION
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes use of `CURLOPT_FOLLOWLOCATION` to allow a redirect on github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr solves an issue where github redirected while the plugin tried to download the k6 binary by using curl instead of
file_get_contents.I had the issue several times while I tried to set up stress testing in my ci workflow. Github always redirected to
https://objects.githubusercontent.com/<...>.Please let me now if there is anything I need to adjust.
FYI:
composer test:typesfails because of missing./vendor/ergebnis/phpstan-rules/rules.neon(not required incomposer.json) and even with it installed it fails with: