Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove flag PS_22149_THEME_SELECTION_COLORS #1654

Merged
merged 3 commits into from
Jan 9, 2025
Merged

refactor: remove flag PS_22149_THEME_SELECTION_COLORS #1654

merged 3 commits into from
Jan 9, 2025

Conversation

haxxmaxx
Copy link
Collaborator

@haxxmaxx haxxmaxx commented Dec 16, 2024 •
edited
Loading

Motivation

Requirements checklist

  • Api specification
    • Ran yarn spec
      • No changes OR API changes has been formally approved
  • Unit/Component test coverage
  • Correct PR title for the changes (fix, chore, feat)

When build and tests have passed:

  • Add code reviewers, for example @qlik-oss/nebula-core

@haxxmaxx haxxmaxx changed the title fix: remove flag refactor: remove flag PS_22149_THEME_SELECTION_COLORS Dec 19, 2024
@haxxmaxx haxxmaxx marked this pull request as ready for review December 19, 2024 10:14
@haxxmaxx haxxmaxx merged commit 6a543b5 into main Jan 9, 2025
10 checks passed
@haxxmaxx haxxmaxx deleted the crl/remove-flag branch January 9, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Caele Caele Caele approved these changes

@T-Wizard T-Wizard Awaiting requested review from T-Wizard

@niekvanstaveren niekvanstaveren Awaiting requested review from niekvanstaveren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haxxmaxx @Caele