Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating python call to python3 #258

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

EmbeddedDevops1
Copy link
Collaborator

@EmbeddedDevops1 EmbeddedDevops1 commented Jan 7, 2025

PR Type

enhancement


Description

  • Updated the Makefile to use python3 instead of python.

  • Ensures compatibility with environments where python3 is explicitly required.


Changes walkthrough 📝

Relevant files
Enhancement
Makefile
Update `python` command to `python3` in Makefile                 

Makefile

  • Changed the python command to python3 in the SITE_PACKAGES variable.
  • Ensures compatibility with systems where python3 is the default Python
    version.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 7, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Add error handling for missing dependencies to prevent silent failures

    Add error handling to check if the wandb module is installed before trying to access
    its path. The current code will fail silently if wandb is not available.

    Makefile [2]

    -SITE_PACKAGES=$(shell python3 -c "import wandb, os; print(os.path.dirname(wandb.__file__))")
    +SITE_PACKAGES=$(shell python3 -c "try:\n  import wandb, os\n  print(os.path.dirname(wandb.__file__))\nexcept ImportError:\n  exit('Error: wandb package not found')")
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: The suggestion adds crucial error handling that will prevent silent failures and provide clear feedback when the required 'wandb' package is missing, which is essential for build reliability and debugging.

    8

    @EmbeddedDevops1 EmbeddedDevops1 merged commit 4b0ac90 into main Jan 7, 2025
    7 checks passed
    @EmbeddedDevops1 EmbeddedDevops1 deleted the modify-python-path branch January 7, 2025 04:49
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant