Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip install packages for regression test pipeline. #260

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

EmbeddedDevops1
Copy link
Collaborator

@EmbeddedDevops1 EmbeddedDevops1 commented Jan 7, 2025

PR Type

enhancement, bug fix


Description

  • Added new Python packages (tree_sitter, diff-cover) to the regression test pipeline.

  • Fixed Python version inconsistency in Makefile for diff_cover template path.

  • Enhanced dependency installation process in the nightly regression workflow.


Changes walkthrough 📝

Relevant files
Enhancement
nightly_regression.yml
Update dependencies in nightly regression workflow             

.github/workflows/nightly_regression.yml

  • Added tree_sitter and diff-cover to the pip install command.
  • Improved dependency installation for the nightly regression workflow.
  • +1/-1     
    Bug fix
    Makefile
    Fix Python version inconsistency in Makefile                         

    Makefile

  • Fixed Python version inconsistency for diff_cover template path.
  • Updated python to python3 in Makefile.
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 7, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Package Versions

    The pip install command does not specify package versions, which could lead to compatibility issues if newer incompatible versions are released

    pip install poetry wandb tree_sitter diff-cover

    Copy link
    Contributor

    qodo-merge-pro bot commented Jan 7, 2025

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    Pin dependency versions to ensure consistent and reproducible builds across different environments

    Pin the package versions in the pip install command to ensure reproducible builds
    and avoid potential breaking changes from newer versions.

    .github/workflows/nightly_regression.yml [34]

    -pip install poetry wandb tree_sitter diff-cover
    +pip install poetry==1.7.1 wandb==0.16.1 tree-sitter==0.20.2 diff-cover==8.0.1
    • Apply this suggestion
    Suggestion importance[1-10]: 8

    Why: Pinning dependency versions is crucial for CI/CD workflows to ensure build reproducibility and prevent unexpected failures due to package updates. This is especially important in a nightly regression workflow where consistency is key.

    8

    @EmbeddedDevops1 EmbeddedDevops1 merged commit 5c8ca2c into main Jan 7, 2025
    1 check passed
    @EmbeddedDevops1 EmbeddedDevops1 deleted the hotfix/fix-regression-pipeline branch January 7, 2025 05:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant