Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cocoa] Add handler for javascript prompt/input. #1567

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maddyaby
Copy link
Contributor

@maddyaby maddyaby commented Jan 6, 2025

Cocoa was missing handler for calling prompt("...")

This adds the popup and input handling. It also adds the Edit menu item to handle cut/copy/paste for subviews and modals in addition to the main view

@maddyaby maddyaby force-pushed the prompt_handler_macos branch from 3eb965b to d4c31c3 Compare January 8, 2025 01:34
Cocoa was missing handler for calling prompt("...")

This adds the popup and input handling
…erts, etc.

The existing implementation in the keyDown_ handler only works on items in the main view and not in subviews/modals
@maddyaby maddyaby force-pushed the prompt_handler_macos branch from d4c31c3 to a92e0be Compare January 8, 2025 19:10
@r0x0r
Copy link
Owner

r0x0r commented Jan 8, 2025

Prompt works fine, but there is no Edit menu item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants