[Cocoa] Fix location that new subviews get added #1569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y axis is flipped for the web coordinate system vs. the window, so events originating from the webview will have flipped coordinates
|
So this flips the coordinates for any call to addSubview... not sure if we want to restrict it to only ones that originate from the webview (but I don't know how to do that :( ). Do we expect any other originators of addSubview beyond the first call that adds the WKFlippedView container for the webview, and calls that originate from the webview itself? |
|
Good job on fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Cocoa] Fix location that new subviews get added
Y axis is flipped for the web coordinate system vs. the window, so events originating from the webview will have flipped coordinates
Resolves #1568