Remove unnecessary CUDA utilities #4855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bdice
commented
Jan 8, 2025
| @@ -56,7 +56,6 @@ def _get_feasibility(G, sources, components=None, depth_limit=None): | |||
|
|
|||
| # Fixme not implemented in RMM yet | |||
There was a problem hiding this comment.
This should probably use rmm.mr.available_device_memory() but this function is currently unreachable due to the NotImplementedError thrown on line 149 below. It seems it would be better to rework this entirely once the feature is implemented.
bdice
added
improvement
jameslamb
approved these changes
Jan 8, 2025
bdice
commented
Jan 9, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some utilities that were updated in #4830 but are no longer needed.
xref: rapidsai/build-planning#117