Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics for wgpu backend and whether the viewer runs in WSL #8612

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 8, 2025

Today we're driving blind on some of the key questions around Rerun Viewer usage. This PR adds three new properties to the viewer_started analytics event:

  • is_wsl
    • a boolean indicating whether the viewer has been started directly from the WSL
    • we're interested in this because we want to understand the importance of WSL support
  • graphics_adapter_backend
    • a string identifying which of the wgpu backends is used
    • we're interested in this because we want to know which graphics backends are the most important
      • The most important distinction here is gl (webgl + desktop gl) vs webgpu vs everything else. We want to understand when the right time is to phase out support for gl.
  • re_renderer_device_tier
    • a string identifying which of the (today two) device tiers re_renderer settled on for a given viewer session
    • similar to the above this gives us a (very) rough idea of what abilities the graphics adapter has
    • it's likely that we'll add one or two more tiers in the future

As always we're trying to be considerate with what we add to our analytics in order to be intrusive while providing valuable information to inform the development of Rerun.
If you want to learn more about analytics run rerun analytics details.
If you have a complaint about the intrusiveness of these analytics please reach out.


Examples of what we see on Posthog with this:

Starting viewer on Windows:
image

Starting viewer from WSL (with #8610 merged in):
image

Starting the viewer from the Browser @ WebGL:
image

Starting the viewer from the Browser @ WebGPU:
image

Copy link

github-actions bot commented Jan 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
37e8123 https://rerun.io/viewer/pr/8612 +nightly +main

Note: This comment is updated whenever you push a commit.

@emilk emilk self-requested a review January 9, 2025 09:31
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Wumpf Wumpf merged commit 6f929cf into main Jan 9, 2025
31 checks passed
@Wumpf Wumpf deleted the andreas/analytics-wsl-and-wgpu-backend branch January 9, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants