Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
re_grpc_server
#8451What
This PR introduces a new gRPC service which behaves similarly to our existing TCP and WS comms.
WriteMessages
rpc will be stored in a buffer, and broadcast to all callers ofReadMessages
.ReadMessages
will also yield the full history.server_memory_limit
, then messages are dropped in oldest first order (FIFO).TODO:
SizeBytes
impl inre_protos
to measure size of stored messages instead of approximating viaMessage::encoded_len