Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement re_grpc_server #8622

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Implement re_grpc_server #8622

wants to merge 7 commits into from

Conversation

jprochazk
Copy link
Member

Related

What

This PR introduces a new gRPC service which behaves similarly to our existing TCP and WS comms.

  • Any messages logged via the WriteMessages rpc will be stored in a buffer, and broadcast to all callers of ReadMessages.
  • Any calls to ReadMessages will also yield the full history.
  • If the buffer fills up beyond server_memory_limit, then messages are dropped in oldest first order (FIFO).

TODO:

  • Use a SizeBytes impl in re_protos to measure size of stored messages instead of approximating via Message::encoded_len
  • Add a test for the memory limit

@jprochazk jprochazk marked this pull request as draft January 8, 2025 20:12
Copy link

github-actions bot commented Jan 8, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
f59825a https://rerun.io/viewer/pr/8622 +nightly +main

Note: This comment is updated whenever you push a commit.

@jprochazk jprochazk added the 🪵 Log & send APIs Affects the user-facing API for all languages label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages remote-store remote store gRPC API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement re_grpc_server
1 participant