Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.7 (EOL) & Add Ruby 3.2 #30

Merged
merged 4 commits into from
Mar 30, 2023
Merged

Conversation

julitrows
Copy link
Contributor

@julitrows julitrows commented Mar 30, 2023

Unsure if the version should be handled otherwise. 2.2.0? 3.0.0?

@julitrows julitrows self-assigned this Mar 30, 2023
@julitrows julitrows requested a review from iovis March 30, 2023 13:34
matrix:
ruby: [2.7.x, 3.0.x, 3.1.x]
ruby: ['3.0.5', '3.1.3', '3.2.1']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this with the previous format? 3.0.x, ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed them because that was breaking the build.

https://github.com/rubiconmd/injectable/actions/runs/4565081658

I think this is related? ruby/setup-ruby#447

I can add every patch-level, but it seems overkill?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, then nvm haha. Nah, don't add more, those are fine

@julitrows julitrows merged commit 2bf5390 into master Mar 30, 2023
@julitrows julitrows deleted the julio/ruby-3.2 branch March 30, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants