Pass deployment target with -m*-version-min=
#1339
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
deployment-target-version
branch
from
93ae083 to
5fc270a
Compare
Clang's supports many ways of passing the deployment target, and prefers that you use the `-target` flag for doing so. This works poorly work with configuration files, which Homebrew's LLVM uses, so we use the `-mmacosx-version-min=`, `-miphoneos-version-min=`, `-mtargetos=` etc. flags to pass the deployment target instead.
Since we no longer version the LLVM target, it is no longer that important to call out that the LLVM target is unversioned.
madsmtm
force-pushed
the
deployment-target-version
branch
from
5fc270a to
e1d028b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang's supports many ways of passing the deployment target, and prefers that you use the
-targetflag for doing so.This works poorly work with configuration files though, which Homebrew's LLVM uses, so we use the
-mmacosx-version-min=,-miphoneos-version-min=,-mtargetos=etc. flags to pass the deployment target instead. See also discussion in Homebrew/homebrew-core#197532.I will be submitting a similar PR to
rustcat some point to fix this in there too.Fixes #1278.