-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: opt-out @tanstack/react-virtual
from React Compiler
#7891
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some testing myself, this seems to work as expected 🙏
Thanks Cody
Component Testing Report Updated Nov 27, 2024 2:23 PM (UTC) ✅ All Tests Passed -- expand for details
|
⚡️ Editor Performance ReportUpdated Wed, 27 Nov 2024 14:29:44 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
Description
Adding React Compiler caused a regression in paths that uses
import {useVirtualizer} from '@tanstack/react-virtual'
. It's a known issue, and I've subscribed to the issue so I get notified when we can come back and remove the'use no memo'
directives 👍What to review
This should fix SAPP-1945, repro: https://test-studio.sanity.dev/test/structure/input-standard;arraysTest;18db9a51-b3fe-4843-94a6-c5a2ba6ac039
Testing
Didn't have time to add an E2E test that covers this case, but it might be worth doing in a follow-up 🙌 Manually tested by checking http://localhost:3333/test/structure/input-standard;arraysTest;18db9a51-b3fe-4843-94a6-c5a2ba6ac039 and scrolling, verifying that array reference items render without focusing/clicking first.
Notes for release
Fixes a regression introduced in
v3.65.0
where array list references rendered far too lazily, and required focus or clicking, when initially "below the fold" of the browser window. They now correctly render on scroll ✨