Initial pass at strimzi sample using the spec #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur De Magalhaes <[email protected]>
scothis
reviewed
Jul 7, 2020
Co-authored-by: Scott Andrews <[email protected]>
Co-authored-by: Scott Andrews <[email protected]>
Co-authored-by: Scott Andrews <[email protected]>
Co-authored-by: Scott Andrews <[email protected]>
Co-authored-by: Navid Shakibapour <[email protected]>
Co-authored-by: Navid Shakibapour <[email protected]>
Co-authored-by: Navid Shakibapour <[email protected]>
nebhale
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the strimzi sample off the main
specrepo. Converted to use the spec'sServiceBindingCR. Things aren't actually working because SBO needs to implement parts of the spec, but at least it's more representative of what the sample should look like.Signed-off-by: Arthur De Magalhaes [email protected]