Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable relative color syntax #34897

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Loirooriol
Copy link
Contributor

Upgrades Stylo to servo/stylo#107


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • There are tests for these changes

@Loirooriol Loirooriol added the T-linux-wpt-2020 Do a try run of the WPT label Jan 8, 2025
@github-actions github-actions bot removed the T-linux-wpt-2020 Do a try run of the WPT label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

🔨 Triggering try run (#12673472183) for Linux WPT

Copy link

github-actions bot commented Jan 8, 2025

Test results for linux-wpt-layout-2020 from try job (#12673472183):

Flaky unexpected result (21)
  • OK /_webgl/conformance/rendering/texture-switch-performance.html (#23384)
    • FAIL [expected PASS] subtest: WebGL test #0: Texture switching significantly hurt performance - achieved 599 frames in 2.003 seconds (0.61 times baseline performance)

      assert_true: Texture switching significantly hurt performance - achieved 599 frames in 2.003 seconds (0.61 times baseline performance) expected true got false
      

  • OK /_webgl/conformance2/rendering/texture-switch-performance.html (#23384)
    • FAIL [expected PASS] subtest: WebGL test #0: Texture switching significantly hurt performance - achieved 531 frames in 2.009 seconds (0.60 times baseline performance)

      assert_true: Texture switching significantly hurt performance - achieved 531 frames in 2.009 seconds (0.60 times baseline performance) expected true got false
      

  • PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
  • OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
    • PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with form submission
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
    • PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
  • TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse-during-unload.html (#28688)
    • TIMEOUT [expected PASS] subtest: Traversing the history during unload

      Test timed out
      

  • TIMEOUT [expected PASS] /html/browsers/origin/origin-keyed-agent-clusters/popups-crash.https.html
  • ERROR [expected TIMEOUT] /html/canvas/element/manual/imagebitmap/createImageBitmap-transfer.html (#34119)
  • OK /html/dom/render-blocking/script-inserted-style-element.html
    • PASS [expected FAIL] subtest: Rendering is blocked before render-blocking resources are loaded
  • OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-location-replace-set-src.html (#32697)
    • PASS [expected FAIL] subtest: Navigating iframe loading='lazy' and then setting src: location.replace
  • OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
      

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
      

  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • PASS [expected FAIL] subtest: text/plain: backslash in filename (formdata event)
  • TIMEOUT [expected OK] /performance-timeline/navigation-id-detached-frame.tentative.html (#34773)
    • TIMEOUT [expected PASS] subtest: The navigation_id getter does not crash a window of detached frame

      Test timed out
      

  • OK /resize-observer/change-layout-in-error.html (#32629)
    • PASS [expected FAIL] subtest: Changing layout in window error handler should not result in lifecyle loop when resize observer loop limit is reached.
  • TIMEOUT [expected OK] /webmessaging/without-ports/018.html (#24485)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:

      Test timed out
      

  • OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
  • OK /workers/WorkerGlobalScope-close.html (#23064)
    • PASS [expected FAIL] subtest: Test sending a message after closing.
Stable unexpected results that are known to be intermittent (10)
  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • PASS [expected FAIL] subtest: Check execution order on load handler
    • PASS [expected FAIL] subtest: Check execution order from nested timeout
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
    • PASS [expected FAIL] subtest: link click
  • OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)
    • FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

      assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"
      

  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])
      

  • CRASH [expected OK] /html/canvas/offscreen/canvas-host/2d.canvas.host.size.large.worker.html (#30164)
  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
  • OK /navigation-timing/test-navigation-type-reload.html (#33334)
    • PASS [expected FAIL] subtest: Reload domComplete > Original domComplete
    • PASS [expected FAIL] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
    • PASS [expected FAIL] subtest: Reload domInteractive > Original domInteractive
    • PASS [expected FAIL] subtest: Reload fetchStart > Original fetchStart
    • PASS [expected FAIL] subtest: Reload loadEventEnd > Original loadEventEnd
    • PASS [expected FAIL] subtest: Reload loadEventStart > Original loadEventStart
  • OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
    • PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results (7)
  • OK /html/canvas/element/fill-and-stroke-styles/2d.fillStyle.relativecolor.currentcolor.html
    • PASS [expected FAIL] subtest: Relative color works as color input with currentcolor
  • OK /html/canvas/element/fill-and-stroke-styles/2d.fillStyle.relativecolor.html
    • PASS [expected FAIL] subtest: Relative color works as color input
  • OK /html/canvas/element/fill-and-stroke-styles/2d.strokeStyle.relativecolor.html
    • PASS [expected FAIL] subtest: Relative color works as color input
  • OK /html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.relativecolor.html
    • PASS [expected FAIL] subtest: Relative color works as color input
  • OK /html/canvas/offscreen/fill-and-stroke-styles/2d.fillStyle.relativecolor.worker.html
    • PASS [expected FAIL] subtest: Relative color works as color input
  • OK /html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.relativecolor.html
    • PASS [expected FAIL] subtest: Relative color works as color input
  • OK /html/canvas/offscreen/fill-and-stroke-styles/2d.strokeStyle.relativecolor.worker.html
    • PASS [expected FAIL] subtest: Relative color works as color input

Copy link

github-actions bot commented Jan 8, 2025

⚠️ Try run (#12673472183) failed.

@Loirooriol Loirooriol force-pushed the enable-relative-color-syntax branch from c22fd61 to 0bdb28c Compare January 8, 2025 15:41
@Loirooriol Loirooriol marked this pull request as ready for review January 8, 2025 15:41
@Loirooriol Loirooriol requested a review from mrobinson January 8, 2025 15:41
@Loirooriol Loirooriol force-pushed the enable-relative-color-syntax branch from 0bdb28c to 282164a Compare January 8, 2025 17:26
Upgrades Stylo to servo/stylo#107

Signed-off-by: Oriol Brufau <[email protected]>
@Loirooriol Loirooriol force-pushed the enable-relative-color-syntax branch from 282164a to cedd043 Compare January 8, 2025 17:29
@Loirooriol Loirooriol enabled auto-merge January 8, 2025 17:30
@Loirooriol Loirooriol added this pull request to the merge queue Jan 8, 2025
Merged via the queue into servo:main with commit 51a1aeb Jan 8, 2025
22 checks passed
@Loirooriol Loirooriol deleted the enable-relative-color-syntax branch January 8, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants