-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate kt tests off hamcrest #13888
Open
jamesonwilliams
wants to merge
22
commits into
signalapp:main
Choose a base branch
from
jamesonwilliams:migrate-kt-tests-off-hamcrest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate kt tests off hamcrest #13888
jamesonwilliams
wants to merge
22
commits into
signalapp:main
from
jamesonwilliams:migrate-kt-tests-off-hamcrest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234
syntaxDescription
In #13884, I am migrating the remaining Java/Hamcrest tests to Kotlin/AssertK.
In this PR, I am migrating the remaining Kotlin/Hamcrest tests to Kotlin/Assert. There are uses of Hamcrest in both the unit and connected device tests. A good number of these are under-the-hood via helper functions in
KotlinAssertsUtil.kt
andTestUtils.kt
.To find the remaining Kotlin files that still use Hamcrest, I used:
rg hamcrest $(git ls-files "app*.kt") $(git ls-files "*lib*kt")
And replaced every call site with the equivalent AssertK expression. (Frequently using a find/replace regex and then cleaning up by hand.)
Testing
^
FixInAppCurrencyIfAbleTest
fails; but it does without these changes, too. So, the results of the suite are unchanged, and the failure is not related to this set of changes.