Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor usability improvement: Add a few 'buffer-days' in case of 1-Year 'KeepMessagesDuration' #13889

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor usability improvement: Add a few 'buffer-days' in case of 1-Year 'KeepMessagesDuration' #13889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/org/thoughtcrime/securesms/keyvalue/KeepMessagesDuration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@

public enum KeepMessagesDuration {
FOREVER(0, R.string.preferences_storage__forever, Long.MAX_VALUE),
ONE_YEAR(1, R.string.preferences_storage__one_year, TimeUnit.DAYS.toMillis(365)),
//Remark: Simply adding a few "buffer-days" to 365 increases the usability wrt annually messages (good wishes for birthday, New Year, etc), so that users are still able to cross-check, what exact wording they have written to a person 1 year before (e.g. to avoid writing always the same)
ONE_YEAR(1, R.string.preferences_storage__one_year, TimeUnit.DAYS.toMillis(365+3)),
SIX_MONTHS(2, R.string.preferences_storage__six_months, TimeUnit.DAYS.toMillis(183)),
THIRTY_DAYS(3, R.string.preferences_storage__thirty_days, TimeUnit.DAYS.toMillis(30));

Expand Down