Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use screen capture for slides snapshot #1988

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Dec 27, 2024

Use the same screenshot logic from #1972 by @KermanX, remove the previous html-to-image approach.

@antfu antfu requested a review from KermanX December 27, 2024 04:38
Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 8e1edc8
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/676eb5cc96dc7b000877aba1
😎 Deploy Preview https://deploy-preview-1988--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 27, 2024

Open in Stackblitz

@slidev/client

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/client@1988

create-slidev-theme

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev-theme@1988

@slidev/parser

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/parser@1988

create-slidev

npm i https://pkg.pr.new/slidevjs/slidev/create-slidev@1988

@slidev/cli

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/cli@1988

@slidev/types

npm i https://pkg.pr.new/slidevjs/slidev/@slidev/types@1988

commit: 8e1edc8

Copy link
Member

@KermanX KermanX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about capturing multiple slides simultaneously, which will make the process faster? But this requires more work and introduces complexity, I am not sure if it is worth it.

@antfu antfu merged commit de44e2d into main Dec 27, 2024
10 of 11 checks passed
@antfu antfu deleted the feat/use-screencapture-snapshots branch December 27, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick overview opening slowly on larger presentations Snapshot overview not color mode aware
2 participants