Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSPL-2577 - Add an option for path Style URL #1333

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

CSPL-2577 - Add an option for path Style URL #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8f04ab
Add an option for path Style URL
akondur May 22, 2024
c4c14b5
Added changes to incorporate s3PathUrl at creation time vs update
akondur Jun 6, 2024
d2ebb62
Merge remote-tracking branch 'origin/develop' into CSPL-2577
akondur Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/v4/common_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,10 @@ type VolumeSpec struct {

// Region of the remote storage volume where apps reside. Used for aws, if provided. Not used for minio and azure.
Region string `json:"region"`

// Type of URL for S3 endpoints. Configure true for path sytle URL. False by default(Host style)
// https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
S3PathUrl bool `json:"s3PathUrl"`
}

// VolumeAndTypeSpec used to add any custom varaibles for volume implementation
Expand Down
17 changes: 17 additions & 0 deletions config/crd/bases/enterprise.splunk.com_clustermanagers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1036,6 +1036,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -2129,6 +2133,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -4099,6 +4107,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -4367,6 +4380,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
17 changes: 17 additions & 0 deletions config/crd/bases/enterprise.splunk.com_clustermasters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -2125,6 +2129,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -4095,6 +4103,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -4360,6 +4373,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
9 changes: 9 additions & 0 deletions config/crd/bases/enterprise.splunk.com_licensemanagers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,6 +1026,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -3973,6 +3977,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
9 changes: 9 additions & 0 deletions config/crd/bases/enterprise.splunk.com_licensemasters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,6 +1021,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -3968,6 +3972,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
18 changes: 18 additions & 0 deletions config/crd/bases/enterprise.splunk.com_monitoringconsoles.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,6 +1028,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -3974,6 +3978,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -5154,6 +5163,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -8100,6 +8113,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
18 changes: 18 additions & 0 deletions config/crd/bases/enterprise.splunk.com_searchheadclusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,6 +1034,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -3997,6 +4001,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -5247,6 +5256,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -8210,6 +8223,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
34 changes: 34 additions & 0 deletions config/crd/bases/enterprise.splunk.com_standalones.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,6 +1029,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -2126,6 +2130,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -4097,6 +4105,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -4359,6 +4372,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -5399,6 +5416,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -6496,6 +6517,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -8467,6 +8492,11 @@ spec:
apps reside. Used for aws, if provided. Not used for
minio and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure
true for path sytle URL. False by default(Host style)
https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down Expand Up @@ -8732,6 +8762,10 @@ spec:
reside. Used for aws, if provided. Not used for minio
and azure.
type: string
s3PathUrl:
description: Type of URL for S3 endpoints. Configure true
for path sytle URL. False by default(Host style) https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
type: boolean
secretRef:
description: Secret object name
type: string
Expand Down
13 changes: 13 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,19 @@ require (
)

require (
github.com/aws/aws-sdk-go-v2 v1.26.1 // indirect
github.com/aws/aws-sdk-go-v2/config v1.27.11 // indirect
github.com/aws/aws-sdk-go-v2/credentials v1.17.11 // indirect
github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.16.1 // indirect
github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.5 // indirect
github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.5 // indirect
github.com/aws/aws-sdk-go-v2/internal/ini v1.8.0 // indirect
github.com/aws/aws-sdk-go-v2/service/internal/accept-encoding v1.11.2 // indirect
github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.11.7 // indirect
github.com/aws/aws-sdk-go-v2/service/sso v1.20.5 // indirect
github.com/aws/aws-sdk-go-v2/service/ssooidc v1.23.4 // indirect
github.com/aws/aws-sdk-go-v2/service/sts v1.28.6 // indirect
github.com/aws/smithy-go v1.20.2 // indirect
github.com/bahlo/generic-list-go v0.2.0 // indirect
github.com/beorn7/perks v1.0.1 // indirect
github.com/buger/jsonparser v1.1.1 // indirect
Expand Down
Loading
Loading