Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Use ink in CLI #30202

Draft
wants to merge 24 commits into
base: next
Choose a base branch
from
Draft

CLI: Use ink in CLI #30202

wants to merge 24 commits into from

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 7, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 692 B -0.31 0%
initSize 131 MB 132 MB 816 kB 0.1 0.6%
diffSize 53 MB 53.8 MB 816 kB 0.1 1.5%
buildSize 7.19 MB 7.19 MB 39 B 2.26 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B - 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B -1.22 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.91 MB 3.91 MB 0 B -1.22 0%
buildPreviewSize 3.28 MB 3.28 MB 39 B 2.25 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.6s 6.7s 72ms -1.23 1.1%
generateTime 19.2s 20.6s 1.3s -0.01 6.6%
initTime 13.7s 13s -747ms -0.77 -5.7%
buildTime 9s 9.6s 594ms -0.04 6.1%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.9s 4.6s -296ms -1.09 -6.4%
devManagerResponsive 3.7s 3.3s -334ms -1.36 🔰-9.9%
devManagerHeaderVisible 586ms 643ms 57ms 0.02 8.9%
devManagerIndexVisible 617ms 655ms 38ms -0.37 5.8%
devStoryVisibleUncached 2s 1.9s -73ms -0.26 -3.7%
devStoryVisible 618ms 683ms 65ms -0.06 9.5%
devAutodocsVisible 444ms 520ms 76ms -0.69 14.6%
devMDXVisible 502ms 688ms 186ms 1.92 🔺27%
buildManagerHeaderVisible 642ms 685ms 43ms 0.45 6.3%
buildManagerIndexVisible 741ms 822ms 81ms 0.8 9.9%
buildStoryVisible 610ms 669ms 59ms 0.64 8.8%
buildAutodocsVisible 548ms 447ms -101ms -1.1 -22.6%
buildMDXVisible 487ms 478ms -9ms -0.34 -1.9%

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

Generated by 🚫 dangerJS against 1a5fe81

Copy link

nx-cloud bot commented Jan 7, 2025

View your CI Pipeline Execution ↗ for commit 1a5fe81.

Command Status Duration Result
nx run-many -t build --parallel=3 ❌ Failed 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-08 15:17:24 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Jan 7, 2025

Package Benchmarks

Commit: 1a5fe81, ran on 8 January 2025 at 15:24:21 UTC

The following packages have significant changes to their size or dependencies:

@storybook/experimental-addon-test

Before After Difference
Dependency count 60 60 0
Self size 975 KB 1.00 MB 🚨 +27 KB 🚨
Dependency size 14.15 MB 14.15 MB 🚨 +78 B 🚨
Bundle Size Analyzer Link Link

@storybook/core

Before After Difference
Dependency count 53 54 🚨 +1 🚨
Self size 19.08 MB 19.60 MB 🚨 +524 KB 🚨
Dependency size 14.43 MB 14.72 MB 🚨 +290 KB 🚨
Bundle Size Analyzer Link Link

@storybook/react-native-web-vite

Before After Difference
Dependency count 114 105 🎉 -9 🎉
Self size 43 KB 42 KB 🎉 -1 KB 🎉
Dependency size 18.22 MB 18.04 MB 🎉 -184 KB 🎉
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 54 55 🚨 +1 🚨
Self size 22 KB 24 KB 🚨 +2 KB 🚨
Dependency size 33.51 MB 34.32 MB 🚨 +814 KB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 55 56 🚨 +1 🚨
Self size 1 KB 1 KB 0 B
Dependency size 33.53 MB 34.35 MB 🚨 +816 KB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 396 397 🚨 +1 🚨
Self size 496 KB 245 KB 🎉 -252 KB 🎉
Dependency size 75.42 MB 76.70 MB 🚨 +1.27 MB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 276 277 🚨 +1 🚨
Self size 612 KB 612 KB 0 B
Dependency size 65.32 MB 66.14 MB 🚨 +815 KB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 112 113 🚨 +1 🚨
Self size 1.11 MB 1.56 MB 🚨 +454 KB 🚨
Dependency size 42.64 MB 43.46 MB 🚨 +816 KB 🚨
Bundle Size Analyzer Link Link

@ndelangen ndelangen self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant