This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Update names of iPad devices... #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'ipad2' => 'iPad', | ||
| 'ipad4' => 'iPad Retina', | ||
| 'ipad_air' => 'iPad Retina (64-bit)' | ||
| 'ipad2' => 'iPad 2', |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| @@ -2,6 +2,17 @@ | |||
| require 'xclisten/shell_task' | |||
| require 'listen' | |||
|
|
|||
| IOS_DEVICES = { | |||
| # TODO Update iPhone names. | |||
| 'iphone5s' => 'iPhone Retina (4-inch 64-bit)', | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Please fix the CI system. |
|
The latest diffs also deals with #20. |
|
@fatuhoku thanks! do you mind updating iPhones as well before merging this? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Xcode 6 beta5. Names of the devices have changed around a bit. I think it's best to provide a universal default but the name should be completely overridable.