Add valid locations check #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my main tasks in merging PRs, is fixing the location. Therefor I would somehow like to reuse the validLocations file:
https://github.com/tech-conferences/conference-data/blob/main/scripts/config/validLocations.ts
Currently I've copied it over. Ideally it should somehow be shared between the 2 repos.
Suggesting a new location would also be based on an issue flow. Ideally it should also be possible to suggest a new location directly through the form. But this would require some modifications in the backend as it would also need to modify the validLocations file during the creation of the PR.