Add async render APIs #1365
Closed
Add async render APIs #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d9778c:
|
eps1lon
force-pushed
the
sebbie/async-act
branch
from
1ba3a97 to
c02db2e
Compare
eps1lon
force-pushed
the
sebbie/async-act
branch
from
c02db2e to
571fbc8
Compare
eps1lon
force-pushed
the
sebbie/async-act
branch
2 times, most recently
from
1bb540d to
5ca4927
Compare
Less renaming to-do
eps1lon
force-pushed
the
sebbie/async-act
branch
from
5ca4927 to
9d9778c
Compare
phryneas
reviewed
Nov 29, 2024
Comment on lines
+19
to
+21
| return await React.act(async () => { | ||
| scope() | ||
| }) |
There was a problem hiding this comment.
pretty sure this should be
Suggested change
| return await React.act(async () => { | |
| scope() | |
| }) | |
| return await React.act(async () => { | |
| await scope() | |
| }) |
or
Suggested change
| return await React.act(async () => { | |
| scope() | |
| }) | |
| return await React.act(async () => { | |
| return scope() | |
| }) |
|
We'll with #1214 since this approach doesn't work for libraries like user-event that rely on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not final. For internal testing for now. Alternate to #1214
render(...)->await renderAsync(...)act(...)->await actAsync(...)cleanup(...)->await cleanupAsync(...)renderHook(...)->await renderHookAsync(...)