Merge branch 'main' into test-types

# Conflicts:
#	.github/workflows/release.yml
#	package.json

.github/workflows/release.yml

@@ -14,12 +14,14 @@ jobs:
   main:
     # ignore all-contributors PRs
     if: ${{ !contains(github.head_ref, 'all-contributors') }}
-    name: Node ${{ matrix.node }}, Svelte ${{ matrix.svelte }}
+    name: Node ${{ matrix.node }}, Svelte ${{ matrix.svelte }}, ${{ matrix.test-runner }}
+    runs-on: ubuntu-latest
     strategy:
       matrix:
         node: ['16', '18', '20']
         svelte: ['3', '4']
-    runs-on: ubuntu-latest
+        test-runner: ['vitest:jsdom', 'vitest:happy-dom']
+
     steps:
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v4
@@ -35,7 +37,7 @@ jobs:
           npm install --no-save svelte@${{ matrix.svelte }}
 
       - name: ▶️ Run tests
-        run: npm test
+        run: npm run test:${{ matrix.test-runner }}
 
       - name: ▶️ Run type-checks
         if: ${{ matrix.node == '20' && matrix.svelte == '4' }}

package.json

@@ -52,12 +52,14 @@
     "format:delta": "npm-run-all format:prettier:delta format:eslint:delta",
     "format:prettier:delta": "prettier --write `./scripts/changed-files`",
     "format:eslint:delta": "eslint --fix `./scripts/changed-files`",
+    "setup": "npm install && npm run validate",
     "test": "vitest run --coverage",
     "test:watch": "vitest",
     "test:update": "vitest run --update",
+    "test:vitest:jsdom": "vitest run --coverage --environment jsdom",
+    "test:vitest:happy-dom": "vitest run --coverage --environment happy-dom",
     "types": "svelte-check",
-    "setup": "npm install && npm run validate",
-    "validate": "npm-run-all test types",
+    "validate": "npm-run-all test:vitest:* types",
     "contributors:add": "all-contributors add",
     "contributors:generate": "all-contributors generate"
   },
@@ -85,7 +87,12 @@
     "eslint-plugin-simple-import-sort": "10.0.0",
     "eslint-plugin-svelte": "2.35.1",
     "eslint-plugin-vitest-globals": "1.4.0",
+<<<<<<< HEAD
     "expect-type": "^0.17.3",
+||||||| c568b5d
+=======
+    "happy-dom": "^13.3.1",
+>>>>>>> main
     "jsdom": "^22.1.0",
     "npm-run-all": "^4.1.5",
     "prettier": "3.2.4",

src/__tests__/fixtures/Mounter.svelte

@@ -0,0 +1,11 @@
+<script>
+  import { onDestroy,onMount } from 'svelte'
+
+  export let onMounted
+  export let onDestroyed
+
+  onMount(() => onMounted())
+  onDestroy(() => onDestroyed())
+</script>
+
+<button />

src/__tests__/mount.test.js

@@ -0,0 +1,33 @@
+import { describe, expect, test, vi } from 'vitest'
+
+import { act, render, screen } from '..'
+import Mounter from './fixtures/Mounter.svelte'
+
+describe('mount and destroy', () => {
+  const handleMount = vi.fn()
+  const handleDestroy = vi.fn()
+
+  test('component is mounted', async () => {
+    await act(() => {
+      render(Mounter, { onMounted: handleMount, onDestroyed: handleDestroy })
+    })
+
+    const content = screen.getByRole('button')
+
+    expect(handleMount).toHaveBeenCalledOnce()
+    expect(content).toBeInTheDocument()
+  })
+
+  test('component is destroyed', async () => {
+    const { unmount } = render(Mounter, {
+      onMounted: handleMount,
+      onDestroyed: handleDestroy,
+    })
+
+    await act(() => unmount())
+    const content = screen.queryByRole('button')
+
+    expect(handleDestroy).toHaveBeenCalledOnce()
+    expect(content).not.toBeInTheDocument()
+  })
+})

vite.config.js

@@ -2,14 +2,23 @@ import { svelte } from '@sveltejs/vite-plugin-svelte'
 import { defineConfig } from 'vite'
 
 // https://vitejs.dev/config/
-export default defineConfig({
+export default defineConfig(({ mode }) => ({
   plugins: [svelte()],
+  resolve: {
+    // Ensure `browser` exports are used in tests
+    // Vitest prefers modules' `node` export by default
+    // Svelte's `node` export is its SSR bundle, which does not have onMount
+    // https://github.com/testing-library/svelte-testing-library/issues/222#issuecomment-1909993331
+    conditions: mode === 'test' ? ['browser'] : [],
+  },
   test: {
     environment: 'jsdom',
     setupFiles: ['./src/__tests__/_vitest-setup.js'],
+    mockReset: true,
+    unstubGlobals: true,
     coverage: {
       provider: 'v8',
       include: ['src'],
     },
   },
-})
+}))