Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack2 upgrade WIP #37

Merged
merged 19 commits into from
Jun 11, 2017
Merged

webpack2 upgrade WIP #37

merged 19 commits into from
Jun 11, 2017

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 10, 2016 •
edited
Loading

resolves issue #24 , #45

still WIP

@thescientist13 thescientist13 force-pushed the enhancement/issue-24-updagrade-to-webpack2-beta branch from 28d9de1 to 6c4f27f Compare December 11, 2016 02:20
@thescientist13
Copy link
Member Author

note, webpack 2 (@2.2) has been formally released

@thescientist13
Copy link
Member Author

thescientist13 commented Jun 11, 2017 •
edited
Loading

Seeing this only in dev mode

14:31:39.070 client:40 ./~/@angular/core/src/linker/system_js_ng_module_factory_loader.js
57:15 Critical dependency: the request of a dependency is an expression
CriticalDependencyWarning: Critical dependency: the request of a dependency is an expression
    at SystemImportContextDependency.getWarnings (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/dependencies/SystemImportContextDependency.js:23:4)
    at /Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:645:21
    at Array.forEach (native)
    at /Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:644:22
    at Array.forEach (native)
    at Compilation.reportDependencyWarnings (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:643:9)
    at Compilation.<anonymous> (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:505:8)
    at Array.forEach (native)
    at Compilation.finish (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:504:15)
    at Compiler.<anonymous> (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compiler.js:466:16)
    at /Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/node_modules/tapable/lib/Tapable.js:225:11
    at Compilation.<anonymous> (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:452:10)
    at /Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:423:12
    at /Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/webpack/lib/Compilation.js:335:10
    at /Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/async/lib/async.js:52:16
    at done (/Users/obuckley/Workspace/thegreenhouseio/angular-webapp-seed/node_modules/async/lib/async.js:246:17)
warnings @ client:40
sock.onmessage @ client:82
EventTarget.dispatchEvent @ eventtarget.js:51
(anonymous) @ main.js:274
SockJS._transportMessage @ main.js:272
EventEmitter.emit @ emitter.js:50
WebSocketTransport.ws.onmessage @ websocket.js:35
wrapFn @ zone.js:636
ZoneDelegate.invokeTask @ zone.js:225
Zone.runTask @ zone.js:125
ZoneTask.invoke @ zone.js:293

moved to #56

@thescientist13
Copy link
Member Author

ok to test

1 similar comment
@thescientist13
Copy link
Member Author

ok to test

@thescientist13
Copy link
Member Author

ok to test

@thescientist13
Copy link
Member Author

ok to test

2 similar comments
@thescientist13
Copy link
Member Author

ok to test

@thescientist13
Copy link
Member Author

ok to test

@thescientist13
Copy link
Member Author

ok to test

@thescientist13
Copy link
Member Author

ok to test

@thescientist13 thescientist13 mentioned this pull request Jun 11, 2017
Open
@thescientist13 thescientist13 merged commit 75c543f into master Jun 11, 2017
@thescientist13 thescientist13 deleted the enhancement/issue-24-updagrade-to-webpack2-beta branch June 11, 2017 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thescientist13