Merge pull request #321 from nlemoine/1.x

Fix rounding issue
thephpleague · May 20, 2021 · 753bc82 · 753bc82
2 parents 13c3f94 + 0116ce6
commit 753bc82
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/src/Manipulators/Size.php b/src/Manipulators/Size.php
@@ -162,12 +162,14 @@ public function resolveMissingDimensions(Image $image, $width, $height)
             $height = $image->height();
         }
 
-        if (is_null($width)) {
-            $width = $height * ($image->width() / $image->height());
-        }
-
-        if (is_null($height)) {
-            $height = $width / ($image->width() / $image->height());
+        if (is_null($width) || is_null($height)) {
+            $size = (new \Intervention\Image\Size($image->width(), $image->height()))
+              ->resize($width, $height, function ($constraint) {
+                  $constraint->aspectRatio();
+              });
+
+            $width = $size->getWidth();
+            $height = $size->getHeight();
         }
 
         return [

diff --git a/tests/Manipulators/SizeTest.php b/tests/Manipulators/SizeTest.php
@@ -126,6 +126,16 @@ public function testResolveMissingDimensions()
         $this->assertSame([200, 100], $this->manipulator->resolveMissingDimensions($image, null, 100));
     }
 
+    public function testResolveMissingDimensionsWithOddDimensions()
+    {
+        $image = Mockery::mock('Intervention\Image\Image', function ($mock) {
+            $mock->shouldReceive('width')->andReturn(1024);
+            $mock->shouldReceive('height')->andReturn(553);
+        });
+
+        $this->assertSame([411, 222], $this->manipulator->resolveMissingDimensions($image, 411, null));
+    }
+
     public function testLimitImageSize()
     {
         $this->assertSame([1000, 1000], $this->manipulator->limitImageSize(1000, 1000));