Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kernel): add a generic GPIO pin abstraction #239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(kernel): add a generic GPIO pin abstraction #239

wants to merge 1 commit into from

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Aug 18, 2023

No description provided.

@hawkw hawkw requested a review from jamesmunns August 18, 2023 18:09
@hawkw
Copy link
Contributor Author

hawkw commented Aug 18, 2023

@jamesmunns WDYT of this?

@hawkw
Copy link
Contributor Author

hawkw commented Aug 18, 2023

belatedly, i realized that https://docs.rs/embedded-hal-async/0.2.0-alpha.2/embedded_hal_async/digital/trait.Wait.html also exists for waiting on pin IRQs, so...we might be better off just using that? i think my API design is slightly nicer but this is compatible with other embedded-hal-async crates

@hawkw hawkw added area: kernel Related to the cross-platform kernel kind: enhancement New feature or request labels Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmunns jamesmunns Awaiting requested review from jamesmunns

Assignees
No one assigned
Labels
area: kernel Related to the cross-platform kernel kind: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hawkw