chore(justfile): improve cargo bin installation #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch adds a Python script that appends the RFCs in the `rfcs` dir to the mdBook. I'm not 100% convinced this is the "best approach", since the script has to be run before building the mdBook. Alternatively, we could just make the RFCs dir a subdirectory of the mdBook, and require PRs that add new RFCs to add them to the index as well. That requires more effort when adding an RFC, and means they can no longer live in a top-level `rfcs/` directory. But, on the other hand, it means you don't have to run a big wad of random janky python before you can generate the book. @jamesmunns WDYT?
Depends on #240 This branch improves how the Justfile installs Cargo commands/other binaries which can be installed through Cargo. In addition, it adds optional support for installing Cargo binaries using [`cargo-binstall`] for faster installations, if a `cargo-binstall` binary is present. [`cargo-binstall`]: https://github.com/cargo-bins/cargo-binstall
jamesmunns
approved these changes
Aug 25, 2023
hawkw
force-pushed
the
eliza/rfc-mdbook
branch
from
b77e544 to
c881e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #240
This branch improves how the Justfile installs Cargo commands/other binaries which can be installed through Cargo. In addition, it adds optional support for installing Cargo binaries using
cargo-binstallfor faster installations, if acargo-binstallbinary is present.