tools: fix crowtty cargo alias/just recipe
#344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #342 broke the `cargo crowtty` alias and `just crowtty` Just recipe. This is because we moved the `crowtty` binary out of the workspace's `default-packages`, so that CI builds don't require `libuv`. Because `crowtty` is no longer in `default-package`, running it using `cargo run` now requires passing --pacakge crowtty` as well as `--bin crowtty`, which the aliases don't do. This commit fixes that by adding `--package crowtty` to the `cargo crowtty` alias and the Just recipe. I also documented why crowtty isn't in `default-packages` in the Cargo.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #342 broke the
cargo crowttyalias andjust crowttyJust recipe. This is because we moved thecrowttybinary out of the workspace'sdefault-packages, so that CI builds don't requirelibuv. Becausecrowttyis no longer indefault-package, running it usingcargo runnow requires passing --pacakge crowttyas well as--bin crowtty`, which the aliases don't do.This commit fixes that by adding
--package crowttyto thecargo crowttyalias and the Just recipe. I also documented why crowtty isn't indefault-packagesin the Cargo.toml.