chore: Replace type related to future with standard library #805
Conversation
tottoto
force-pushed
the
replace-type-related-to-future-with-standard-library
branch
from
9724e1d to
e80f387
Compare
|
Looks like (fortunately) none of these are part of the public API. |
| # Internal | ||
| __common = ["futures-core", "pin-project-lite"] |
There was a problem hiding this comment.
If we are removing this, we probably want the removal to appear in the changelog, which may require this change to happen in a dedicated PR.
There was a problem hiding this comment.
Do people really enable features with __-prefixed names? It seems pretty clear that it's internal and may go away at any time..
There was a problem hiding this comment.
The double underscores is clear to me that it's not publicly stable.
There was a problem hiding this comment.
I think the decision to remove it can be postponed.
| @@ -12,7 +12,8 @@ | |||
| //! # Examples | |||
| //! | |||
| //! ```rust | |||
| //! use futures_util::{future::poll_fn, pin_mut}; | |||
| //! use std::future::poll_fn; | |||
| //! use futures_util::pin_mut; | |||
There was a problem hiding this comment.
The standard library also has the pin! macro that can replace this. That may also make sense to update in this PR.
(This isn't the only file using pin_mut.)
There was a problem hiding this comment.
Not possible without bumping MSRV from 1.64 to 1.68.
Replaces the types from futures crates with ones from the standard library.