-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21474 int calculate mileage using dtod for ak oconus shipments #14550
Draft
joeydoyecaci
wants to merge
74
commits into
integrationTesting
Choose a base branch
from
B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
B 21474 int calculate mileage using dtod for ak oconus shipments #14550
joeydoyecaci
wants to merge
74
commits into
integrationTesting
from
B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
+200
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cing needs to be updated
… zip distance looker upper please save me lord
… baby jesus in a tuxedo
…ing post region city ids
MAIN B-21707
MAIN B-21942
…-Shipments' into B-21474-INT-Calculate-Mileage-Using-DTOD-For-AK-OCONUS-Shipments
joeydoyecaci
requested review from
danieljordan-caci,
paulstonebraker,
loganwc,
pambecker and
JonSpight
January 9, 2025 16:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
B-21474
Summary
Adds the ability to use DTOD to calculate mileage if either destination or pickup addresses are OCONUS to support calculation of RDD
###Setup
A breakpoint is required for the following lines
pkg/services/mto_shipment/mto_shipment_updater.go:1226
pkg/services/mto_shipment/mto_shipment_updater.go:1228
How to test
[important] Debugger must be enabled as RDD is not currently displayed
CalculateRequiredDeliveryDate
verify that the country is being populated for both the addresses on lines 1208 and 1216useDTOD
is set to true beforeplanner.ZipTransitDistance
is runplanner.ZipTransitDistance
and verify that DTOD is called to calculate the mileageplanner.ZipTransitDistance