Rename Code Climate related classes #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Code Climate classes were living under the Report namespace but did not all implement report classes. With this change, they are moved to the CodeClimate namespace instead. They are also moved to the lib/reek/code_climate directory to put their file names in line with their namespace name. The spec files are moved as well, fixing an outstanding RSpec/SpecFilePathFormat offense.
|
Nice, I just wanted to look in the Rspec related rubocop failure that popped up in our other PRs but I see you fixed this here as well, merging! |
troessner
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Code Climate classes were living under the Report namespace but did not all implement report classes. With this change, they are moved to the CodeClimate namespace instead. They are also moved to the
lib/reek/code_climatedirectory to put their file names in line with their namespace name.The spec files are moved as well, fixing an outstanding RSpec/SpecFilePathFormat offense.