Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] sort imports in build/index.ts #12833

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

erikareads
Copy link
Contributor

@erikareads erikareads commented Jan 6, 2025

Breaks the imports in build/index.ts into three sorted groups: external dependencies, monorepo dependencies, and other modules in package/cli.

I did this PR as a standalone on one module so that we can discuss whether we:

  • Want to sort our imports?
  • Want to do an automated sweep across other modules in package/cli or the whole repo?
  • Want to enforce import sorting with the formatter/linter?

This particular sort was done using a manual invocation of the Zed 'organize imports' code action.

Copy link

changeset-bot bot commented Jan 6, 2025

🦋 Changeset detected

Latest commit: a80afdb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm down for this, but yes please let's automate it.

@erikareads erikareads added this pull request to the merge queue Jan 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants