Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AOC Leaderboard commands #246

Merged
merged 8 commits into from
Dec 14, 2024
Merged

feat: AOC Leaderboard commands #246

merged 8 commits into from
Dec 14, 2024

Conversation

samhwang
Copy link
Collaborator

  • feat: add aoc key and leaderboard id field
  • feat: add command to set aoc settings
  • feat: create function to fetch AOC data
  • feat: add util functions to get and save leaderboard
  • feat: add command to fetch leaderboard
  • feat: add db migration for aoc models and settings

Description

  • Add a command for admins to set aoc settings (leaderboard ID & session key)
  • Add a command for everyone to get aoc results.

Motivation and Context

Advent of Code is a common activity that VAIT members are participating in for the third year in a row now. Getting this into the server will be an easy way to keep track of the leaderboard.

Related Issue

#243

How Has This Been Tested?

  • Unit tests have all been ran
  • Ran a test in the test server, see screenshots below.

Screenshots (if appropriate):

Screenshot 2024-12-15 at 2 48 49 am The first one is a fresh request, the second one is a repeated request and it will only show the cached one.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@samhwang samhwang requested a review from hp0210 December 14, 2024 20:34
Copy link
Collaborator

@hp0210 hp0210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@samhwang samhwang requested a review from dohaicuong December 14, 2024 20:34
@samhwang samhwang merged commit dd0274d into master Dec 14, 2024
5 checks passed
@samhwang samhwang deleted the aoc-leaderboard-command branch December 14, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants