Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-21.0] schemadiff: skip keys with expressions in Online DDL analysis (#17475) #17480

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jan 8, 2025

Description

This is a backport of #17475

@vitess-bot vitess-bot bot requested a review from shlomi-noach as a code owner January 8, 2025 09:36
@vitess-bot vitess-bot bot added the Backport This is a backport label Jan 8, 2025
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner January 8, 2025 09:36
@vitess-bot vitess-bot bot added Component: schema management schemadiff and schema changes Type: Bug labels Jan 8, 2025
Copy link
Contributor Author

vitess-bot bot commented Jan 8, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot requested a review from notfelineit January 8, 2025 09:36
@github-actions github-actions bot added this to the v21.0.2 milestone Jan 8, 2025
@shlomi-noach shlomi-noach merged commit f527ed7 into release-21.0 Jan 8, 2025
194 checks passed
@shlomi-noach shlomi-noach deleted the backport-17475-to-release-21.0 branch January 8, 2025 10:33
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (47883f1) to head (dfceec3).
Report is 3 commits behind head on release-21.0.

Files with missing lines Patch % Lines
go/vt/schemadiff/onlineddl.go 25.00% 3 Missing ⚠️
go/vt/schemadiff/key.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-21.0   #17480      +/-   ##
================================================
+ Coverage         67.51%   67.53%   +0.02%     
================================================
  Files              1570     1570              
  Lines            251442   251455      +13     
================================================
+ Hits             169756   169824      +68     
+ Misses            81686    81631      -55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport This is a backport Component: schema management schemadiff and schema changes Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant