Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the high performance vllm docker for AMD Rocm. #11877

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

haic0
Copy link

@haic0 haic0 commented Jan 9, 2025

Could you please review the PR and add the following content into the vllm installation Docs. Thanks so much!

Copy link

github-actions bot commented Jan 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@hongxiayang
Copy link
Collaborator

@haic0
This content is similar to the link: https://rocm.docs.amd.com/en/latest/how-to/performance-validation/mi300x/vllm-benchmark.html

Instead of duplicating the content and creating a maintenance overhead, we should just add the link with a simple explanation in this getting-started section (where we already mentioned the MI300x tuning guide: https://github.com/vllm-project/vllm/blob/main/docs/source/getting_started/installation/gpu-rocm.md?plain=1#L161-L162)

@hongxiayang
Copy link
Collaborator

@haic0 Please let me know. I can help to add the link.

@hongxiayang hongxiayang added the documentation Improvements or additions to documentation label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants