mixxx: update to 2.5.0 #53868
Open
mixxx: update to 2.5.0 #53868
+18
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlice
force-pushed
the
mixxx250
branch
2 times, most recently
from
8e0c455 to
04254a2
Compare
zlice
force-pushed
the
mixxx250
branch
2 times, most recently
from
bfef754 to
c754190
Compare
|
The GSL bump looks good to me |
Johnnynator
reviewed
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
Comments
guidelines-support-libraryupdate to 4.1.0 @0x5c (contour and freecad seem to build, no need for bump but can be)mixxxstarted using qt6 but tries to provideQML, which runs a binary and fails on aarch64 crossbuild. i don't think the build was using QML anyway.mixxxalso tries to downloadlibdjinteropthrough cmake, which i was told is not supported in void. it wasn't in the previous version so it should be fine to ditch in 2.5.0