Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prefer-use-template-ref): fix crash when use non-block setup function #2636

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix(prefer-use-template-ref): fix crash when use non-block setup function #2636

merged 1 commit into from
Jan 8, 2025

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Dec 3, 2024

This PR fixes #2635 and add test for it.

FloEdelmann
FloEdelmann approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool, thanks for fixing this so quickly!

@FloEdelmann FloEdelmann requested a review from ota-meshi December 3, 2024 19:25
ota-meshi
ota-meshi approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 4baf3ab into vuejs:master Jan 8, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/prefer-use-template-ref crashes for setup arrow function
3 participants
@ntnyq @FloEdelmann @ota-meshi