Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update link texts upon updates in the URLPattern specification #1707

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Editorial: Update link texts upon updates in the URLPattern specification #1707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a57994c
Update link texts upon updates in the URLPattern specification
yoshisatoyanagisawa Mar 4, 2024
96233ec
Update docs/index.bs
yoshisatoyanagisawa Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions docs/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3357,13 +3357,10 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
:: |rawPattern|, a {{URLPatternCompatible}}
:: |serviceWorker|, a [=/service worker=]
: Output
:: {{URLPattern}}
:: A [=URL pattern=]

1. Let |baseURL| be |serviceWorker|'s [=service worker/script url=].
1. Return the result of [=building a URLPattern from a Web IDL value=] |rawPattern| given |baseURL| and |serviceWorker|'s [=service worker/global object=]'s [=relevant realm=].

Note: Since the [=building a URLPattern from a Web IDL value=] algorithm actually do not depend on the realm, it is fine to call the algorithm here even if the [=service worker/global object=] may not be ready.

1. Return the result of [=building a URL pattern from a Web IDL value=] |rawPattern| given |baseURL|.
</section>

<section algorithm>
Expand All @@ -3379,7 +3376,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/
1. If |condition|["{{RouterCondition/urlPattern}}"] [=map/exists=], then:
1. Let |rawPattern| be |condition|["{{RouterCondition/urlPattern}}"].
1. Let |pattern| be the result of running the <a>Parse URL Pattern</a> algorithm passing |rawPattern| and |serviceWorker|. If this throws an exception, catch it and return false.
1. If |pattern| [=URLPattern/has regexp groups=], then return false.
1. If |pattern| [=URL pattern/has regexp groups=], then return false.

Note: Since running a user-defined regular expression has a security concern, it is prohibited.

Expand Down
Loading