-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace threading.Lock
with asyncio.Lock
when batching to avoid deadlocks
#1270
base: main
Are you sure you want to change the base?
Conversation
…implicit 3.{8,9} behaviour
…te/weaviate-python-client into fix-deadlocks-in-batching
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 93.98% 90.08% -3.91%
==========================================
Files 221 175 -46
Lines 21332 15081 -6251
==========================================
- Hits 20048 13585 -6463
- Misses 1284 1496 +212 ☔ View full report in Codecov by Sentry. |
Great to see you again! Thanks for the contribution. |
…ient into fix-deadlocks-in-batching
Closing in favour of #1371 |
…ient into fix-deadlocks-in-batching
…ient into fix-deadlocks-in-batching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Infrastructure as Code | 0 0 0 0 | View in Orca |
Passed | SAST | 0 0 0 0 | View in Orca |
Passed | Secrets | 0 0 0 0 | View in Orca |
Passed | Vulnerabilities | 0 0 0 0 | View in Orca |
threading.Lock
inasync def
fns toasyncio.Lock
to avoid blocking the event looptime.sleep()
inasync def
fns toasyncio.sleep()
to avoid blocking the event loopBatchObject
instead of_BatchObject
inErrorObject
andBatchReference
instead of_BatchReference
inErrorReference
for easier usage of errorsCloses: #1332