-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: code splitter #8823
base: main
Are you sure you want to change the base?
refactor: code splitter #8823
Conversation
✅ Deploy Preview for rspack ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #8823 will not alter performanceComparing Summary
|
dab14a8
to
d4e7793
Compare
d4e7793
to
159fb7d
Compare
.styleB { | ||
background: blue; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Webpack/Rspack legacy code-splitting bug, you can see entry modules from config is A then B
ac5893a
to
4526881
Compare
maybe we should add a benchmark case with lots of dynamic import module first and to see the bench metrics avoid future regression |
📝 Benchmark detail: Open
|
f7cca63
to
aaec7aa
Compare
18b17a0
to
dc4e2f6
Compare
Summary
Change the algorithm of code-splitting.
Making it more maintainable, concurrent and easy to working with incoming incremental arch.
Because of the multi-threads, now the code-splitting is more performant than before even using single thread. There can be a huge improvement on large repo.
There is a internal test project which contains about 1.5 million chunk modules, using many dynamic imports, costs about 1200 ms to complete a whole code-splitting phase, using the new algorithm on my 15 core MacBook Pro M1, only takse 600 ms to finish !
The detailed benchmark data will be present soon
Checklist